Repository navigation
spec(FIX-2242): closure QA plan for the FIX-2070 messaging epic - #4024
Conversation
One walk on one durable host where the epic's legs collide (a call across a crash, a midway question to a filer parked on a call, a ring beside it), one browser journey, the children's checks under a skip map, the gap sweep, and the removed message names as one rule in the CI sweep beside FIX-2134's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look: FIX-2242 closure QA planSpec-only PR, so this checks direction and claims against 1. D2's premise that "the CI sweep reads tests" is false today (fix before merge)
Consequences for the spec:
2. Two copies of the old list will exist until the goal's sweep is rewired
3. The diff snippet doesn't match the real shapeThe 4. Scope of
|
There was a problem hiding this comment.
Simplify review (FIX-2242 closure spec)
Verdict: The shape of this closure is the right one, and it reuses the last messaging-adjacent closure well. D1 (one Lab walk where legs collide) mirrors FIX-2134 D1 with the same collision argument; D2 (one MESSAGE_NAMES_REMOVED list beside PERSON_STOPS_REMOVED in the FIX-2087 engine) is the same ratchet FIX-2134 used instead of a goal-only sweep. I would not swap this for “re-run children only” or “CI without the walk” — those are correctly rejected.
Where complexity shows up is mostly operational surface area inside the mandated four rows, not the two decisions you’re signing.
What looks heavier than necessary
-
Row 4 vs FIX-2134 precedent — FIX-2134’s gap sweep is one scannable sentence (seams both sides + named docs + epic not done if). Row 4 here inlines seam sub-bullets, every-flow
onMessageReceivedgrep, Messages-view states, docs and a goal-local run of the call example, and queue semantics. That’s a lot of unbounded manual work per closure attempt with no CI twin (unlike D2). Tentative recommendation: collapse row 4 to FIX-2134’s pointer style and push enumerations to the epic seam table or a short mapping table (seam → row-1 assertion / row-3 leg / test / D2), unless you deliberately want row 4 wider than FIX-2130/2134 for this epic. -
Row 3 skip semantics — FIX-2134 says “skipping any whose legs row 1 already walks in full”; this spec adds partial runs and #4021 CI carve-outs in prose. The closure worker will live or die on a skip matrix. Consider adding an explicit table (child goal → legs → full / partial / skip → reason) so row 3 cost doesn’t balloon into re-running
workers-message-each-other1–10c with every control when row 1 already proved the collision legs. Tentative: after row 1, default to controls-only for goals whose epic legs are fully covered — if process allows stating that in the closure report. -
Row 1 + row 2 overlap — Row 1 already anti-games sessions, log, and
getTask; row 2 j1 re-checks Messages view states. Likely still needed forj1:opens-sideand presentation, but worth one sentence on which j1 tags are not implied by row 1 so you don’t pay two flaky passes for the same incident. -
SPEC narrative duplication — Goal prose, flowchart, sequence diagram, and sign-off all tell the same collision story. Template budget (~1k words in SPEC) suggests keeping one diagram plus the signal table (the execution-sharp parts).
-
Retained-spec churn —
#4008,#4021,e2c190e, “in review” in Sign off will age quickly. Stable gates (leg 9 onmain, D2 green) belong here; transient PR state fits Linear or “Notes from review”. -
Figures — D1/D2 SVGs duplicate ~30 lines of CSS each; fine if that’s repo convention (FIX-2134 parity), otherwise a shared frame would be simpler to maintain.
What I would not simplify away
- The new goal
goals/shift-manager/workers-talk-together/and tagged<leg>:<assertion>signal. call-holds-sessionas the one collision no child control breaks.- Scoped
replyToinMESSAGE_NAMES_REMOVED(same class as FIX-2134’s scoped names). - Delegating #4021 budget cases to CI tests in row 3.
Third-party / reuse
No custom sweep engine — extending goals/workforce-coordination/runs-on-one-task/ is the right reuse. Goal cast/world from workers-message-each-other avoids a second fictional lab.
Approval: Directionally correct for a FIX-2070 closure; D1/D2 are not over-scoped. Inline notes are simplification opportunities before or during implementation, not forks on the signed decisions.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc749aa1fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…all as a tool result, rows 3 and 4 trimmed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k
|
Coherence lens on #4024 at bc749aa. D1: approve. It composes existing pieces (the D2: approve the CI intent, but one home. #3985 ( Fixes:
— FSD Architect |
…full name list; leg 9's owner and the new control's file named; the epic's leg a reworded Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k
|
Architect's coherence note folded in f226cfd. I checked each point on
Generated by Claude Code |
|
FSD Architect · coherence note resolved (head The fold matches what I asked. D2 now has one home, two rows in Leg 9's owner is filed as FIX-2260, "FIX-2240's goal leg 9: a message lands once across a crash, on the real model", a child of FIX-2070. Please name FIX-2260 in "Must be green first" in place of the quoted title. One thing is left outside this PR. #3985's "Owned by FIX-2070, swept here" section still says FIX-2249 puts these names in — FSD Architect |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k
…ts 120 s takeover Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k


Requested by Jake · project thread
The problem
Every child of FIX-2070 proves its own leg on a calm host. Nothing yet checks the legs meeting: a call still outstanding when the host dies between its log row and its dispatch, a task's midway question reaching a filer whose request is parked on a call, a ring spending a typed message's budget while a call waits. This is the closure issue's QA plan for the assembled set.
The goal, and how we'll know it's met
On one
maincommit with every other child merged, in Shift Manager on a real model and a durable host, a worker calls another and uses the answer in the request that asked, across a crash between the log write and the dispatch; a message to a task lands in that task's session; a task's midway question reaches its filer while the filer waits on a call; every message lands once; a ring stops inside one typed message's budget; and none of the removed names is in source.goals/shift-manager/workers-talk-together/, reusingworkers-message-each-other's cast and world, on DevTeam over a SQLite store file, killed and restarted.mainbefore FIX-2238 (e2c190e) for legs a, b, c, e and the sweep; five reused child controls (no-debt,send-again,task-to-conversation,no-question-message,no-hop-cap); one new one,call-holds-session, for the collision no child's control breaks.Need your sign-off
D1 · One walk where the legs collide, on one durable host, not the children's checks re-run side by side. The children's checks still re-run in row 3. If wrong: a longer run whose failures are harder to split.
D2 · The removed message names are two rows in the vocabulary sweep's
RETIRED(goals/vocabulary/one-word-per-thing/rules.mjs), the home FIX-2071's renames table (spec(epic): one term, one thing, the coordination renames (FIX-2071) #3985) already gives them:messageWorker,onWorkerMessage, the relay, the two refusals, the old schemas and seen-window state, the entry's first names, andreplyToscoped to Workforce, Shift Manager and the pages. The goal's own sweep then reads the same rows. If wrong: one more row to edit when a name is reused.Merging this PR is the approval.
Everything else
Found on
mainwhile writing this (0c07f1c):main. feat(workforce): a worker message lands once (FIX-2240) #4008 merged with its model-free tests, but without the9:*goal leg and the five controls its spec names. The closure's leg c reuses its faults andno-debt, so it lands first, as its own child of FIX-2070 blocking this issue.packages/shift-manager/test/messages-view.test.tsx:126still renders atakes_tasks_onlyrefusal, which FIX-2238 removed (feat(workforce): a worker can call another worker and wait for the reply (FIX-2239) #4020, FIX-2238 follow-up: a fresh budget for a task held before it starts, and for a person's line in a finished task's session #4021 and feat(workforce): a task's midway question is told to its filer (FIX-2241, part 2) #4022 carry it too).RETIREDreads tests, so the PR adding D2's rows updates that fixture.{ task }in row 3.Review folded: Codex (j1 reads a call as a tool result;
send-againnow graded by a wait again in leg e), Cursor (rows 3 and 4 trimmed, docs line), FSD Architect (D2's home and name list, leg 9's owner, the control's file, the epic's leg a).Docs: no documentation impact; the closure ships checks.
Checks run locally:
scripts/validate-spec-folder.mjs,scripts/check-retired-terms.mjsand the vocabulary sweep pass. Both figures were rendered and checked.Branch:
claude/project-thread-2yzzkg, the branch this session is bound to, notspec/FIX-2242. CI doesn't restrict spec branch names.🤖 Generated with Claude Code
https://claude.ai/code/session_01NczDiEtVsnByx4XbajAf5k